Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: Remove the minopts policy against cctors #90792

Merged
merged 3 commits into from
Sep 1, 2023
Merged

JIT: Remove the minopts policy against cctors #90792

merged 3 commits into from
Sep 1, 2023

Conversation

hez2010
Copy link
Contributor

@hez2010 hez2010 commented Aug 18, 2023 •
edited
Loading

Removed the obsoleted policy.

/cc:@EgorBo

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Aug 18, 2023
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Aug 18, 2023
@ghost
Copy link

ghost commented Aug 18, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Introduce a switch to enable optimizations for cctors.

The plan is to leverage this switch to measure startup performance of some real-world applications, so I would like to ship this switch in net8.0.

Author: hez2010
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@hez2010 hez2010 marked this pull request as draft August 18, 2023 13:28
@hez2010 hez2010 marked this pull request as ready for review August 18, 2023 14:45
@jkotas
Copy link
Member

jkotas commented Aug 18, 2023

The plan is to leverage this switch to measure startup performance of some real-world applications, so I would like to ship this switch in net8.0.

You can build your clrjit.dll with this change, replace it in your .NET 8 setup and measure it that way. This change does not meet the bar for .NET 8 backport.

@build-analysis build-analysis bot mentioned this pull request Aug 18, 2023
Closed
@hez2010 hez2010 changed the title Introduce a switch to use FullOpts for cctors JIT: Remove the minopts policy against cctors Aug 19, 2023
@EgorBo
Copy link
Member

EgorBo commented Aug 20, 2023 •
edited
Loading

I needed opts in CCTORs for my prototype that replaces allocators with frozen allocators but I guess doing that in R2R only is fine.

@JulieLeeMSFT JulieLeeMSFT added this to the 9.0.0 milestone Sep 1, 2023
@JulieLeeMSFT JulieLeeMSFT merged commit 31fc330 into dotnet:main Sep 1, 2023
127 checks passed
@ghost ghost locked as resolved and limited conversation to collaborators Oct 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas left review comments

@EgorBo EgorBo EgorBo approved these changes

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@hez2010 @jkotas @EgorBo @JulieLeeMSFT